Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 2 missing testcases for Keras switch backend #25250

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Added 2 missing testcases for Keras switch backend #25250

merged 1 commit into from
Apr 29, 2019

Conversation

amitsrivastava78
Copy link
Contributor

There was no test cases for the keras backend switch added the same

@Harshini-Gadige Harshini-Gadige self-assigned this Jan 28, 2019
@Harshini-Gadige Harshini-Gadige added awaiting review Pull request awaiting review size:S CL Change Size: Small labels Jan 28, 2019
@Harshini-Gadige Harshini-Gadige added this to Assigned Reviewer in PR Queue via automation Jan 28, 2019
fchollet
fchollet requested changes Jan 29, 2019
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 29, 2019
@amitsrivastava78
Copy link
Contributor Author

@fchollet , thanks for the review, i have updated the code as per the review comments, kindly check and merge.

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Jan 29, 2019
@Harshini-Gadige Harshini-Gadige added the awaiting review Pull request awaiting review label Feb 2, 2019
@amitsrivastava78
Copy link
Contributor Author

@fchollet & @hgadig , can you pls review the PR

@Harshini-Gadige
Copy link

@fchollet & @hgadig , can you pls review the PR

@fchollet PTAL

@amitsrivastava78
Copy link
Contributor Author

@fchollet & @hgadig , all the code is updated as per your comments, can you pls review the PR

@rthadur rthadur requested a review from fchollet April 7, 2019 03:21
@tensorflowbutler
Copy link
Member

Nagging Reviewer @fchollet, @fchollet: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the awaiting review label has been applied.

@rthadur rthadur requested a review from qlzh727 April 21, 2019 15:50
qlzh727
qlzh727 requested changes Apr 22, 2019
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Most of the comment are about variable naming and code style. Thanks.

tensorflow/python/keras/backend_test.py Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Apr 23, 2019
@amitsrivastava78 amitsrivastava78 force-pushed the backend_test branch 2 times, most recently from b275bfa to 4e4dad4 Compare April 23, 2019 14:18
@rthadur rthadur requested a review from qlzh727 April 23, 2019 14:40
qlzh727
qlzh727 requested changes Apr 23, 2019
View reviewed changes
tensorflow/python/keras/backend_test.py Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/backend_test.py Outdated Show resolved Hide resolved
@rthadur rthadur requested a review from qlzh727 April 24, 2019 18:00
@rthadur rthadur added the comp:keras Keras related issues label Apr 24, 2019
@amitsrivastava78
Copy link
Contributor Author

@qlzh727 , i have updated the code as per your suggestion, kindly review.

Regards
Amit

1 similar comment
@amitsrivastava78
Copy link
Contributor Author

@qlzh727 , i have updated the code as per your suggestion, kindly review.

Regards
Amit

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 29, 2019
@tensorflow-copybara tensorflow-copybara merged commit 9886f81 into tensorflow:master Apr 29, 2019
PR Queue automation moved this from Reviewer Requested Changes to Merged Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

@fchollet fchollet Awaiting requested review from fchollet

Assignees

@rthadur rthadur

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@amitsrivastava78 @Harshini-Gadige @tensorflowbutler @fchollet @qlzh727 @googlebot @kokoro-team @tensorflow-copybara @rthadur